Ben33
December 22, 2022, 10:49am
1
Hallo zusammen,
ich muss auch von Boxcryptor umsteigen, vermisse aber ein Feature unter iOS in Cryptomator.
opened 01:19PM - 08 Feb 21 UTC
type:feature-request
storage:onedrive
## Status Quo
OneDrive (personal account): You can access shared folders. If yo… u're unable to access a shared folder that was shared with you (i.e., you are not the owner), you have to [add the shared folder to your OneDrive](https://support.microsoft.com/en-us/office/add-and-sync-shared-folders-to-onedrive-for-home-8a63cd47-1526-4cd8-bd09-ee3f9bfc1504#bkmk_add).
OneDrive for Business (work/school account): You can only access shared folders that you own. Even if you [add a shortcut to "My Files"](https://support.microsoft.com/en-us/office/add-shortcuts-to-shared-folders-in-onedrive-for-work-or-school-d66b1347-99b7-4470-9360-ffc048d35a33), you cannot access the shared folder.
## Technical Details
Currently, Cryptomator sets the permission scope to `Files.ReadWrite` during authentication. However, there is a [difference between OneDrive and OneDrive for Business](https://docs.microsoft.com/en-us/onedrive/developer/rest-api/concepts/direct-endpoint-differences?view=odsp-graph-online#permissions). But even if the scope is set to `Files.ReadWrite.All`, our tests have shown that shared items (not being the owner) still don't magically appear.
To make this point clear: Shortcuts are not part of the [directory listing](https://docs.microsoft.com/en-us/graph/api/driveitem-list-children?view=graph-rest-1.0&tabs=http). That's probably the saddest part about this issue. It seems that there is no way to implement this feature transparently. There is no way to "merge" shared files with your own files. That's actually what the shortcuts are for (in my opinion) but they're missing.
There is an API to list all shared items (not being the owner) via [`GET /me/drive/sharedWithMe`](https://docs.microsoft.com/en-us/graph/api/drive-sharedwithme?view=graph-rest-1.0&tabs=http). With these identifiers, you can access the shared folders. But that's only possible if the permission scope `Files.ReadWrite.All` has been requested and granted.
## Proposed Solution
If we'd like to support this feature, we have to change the permission scope to `Files.ReadWrite.All`. There doesn't seem to be any further restrictions. When changing the permission scope, the user will be prompted to authenticate again. A drawback could be that an admin has to give consent _again_ due to the change (needs further testing).
Since personal accounts are not affected by this issue, the `driveType` should be retrieved and persisted after a successful authentication. You can get it via [`GET /me/drive`](https://docs.microsoft.com/en-us/graph/api/drive-get?view=graph-rest-1.0&tabs=http).
When adding a vault in OneDrive: If the `driveType` is `business` (and maybe `documentLibrary`?!), we need to present a choice between the user's own files and shared items. An optimization could be to detect if there are any shared items at all so that the choice can be skipped. In case of shared items, we need a new screen that lists all available shared folders (shared _files_ don't make any sense here). If one of the folder is selected, the "new" root identifier is the one from the selection (incl. drive identifier).
Caveat: If we set the selected folder as root, there will be the problem that the root folder doesn't have a name (classic example if the vault is the root folder itself). When implementing this feature, we should experiment with setting the parent reference as root but still _showing_ the shared folder directly.
VG
In Cryptomator 2 wurde das eigtl. auch schon so umgesetzt, siehe:
opened 01:22PM - 08 Feb 21 UTC
closed 03:52PM - 03 Jun 21 UTC
type:feature-request
storage:onedrive
When adding OneDrive support, we should consider this as well: https://github.co… m/cryptomator/cryptomator-ios/issues/139
Oder was genau klappt nicht?
Okay, Kommando zurück, vielleicht hat mein Gedächtnis mir einen Streich gespielt und es teilweise mit Google Drive verwechselt. Muss ich mir noch mal genauer anschauen.
Ben33
December 22, 2022, 11:14am
4
Vielen Dank.
Ich möchte auf einen Tresor in einem geteilten Ordner in OneDrive for Business zugreifen.
Ben33
December 22, 2022, 8:03pm
5
Hier noch mal wie es bei Boxcryptor gelöst ist, dort kann ich zwischen meinen eigenen Ordnern und den freigegbenern Ordnern wählen.
Danke, dass du uns noch mal darauf aufmerksam gemacht hast. Ist bei uns leider untergegangen nach unserem Wechsel zu Cryptomator 2 unter iOS. Ich werde noch weitere Tests durchführen und dann entsprechende Issues auf GitHub eröffnen.
Ich gehe davon aus, dass Microsoft das selbst noch nicht gelöst hat über deren Shortcuts, was ich bis heute nicht verstehe (funktioniert im „Personal Account“ ja auch).
Hab’s schon mal hier festgehalten und werde von nun an dort über Neuigkeiten berichten:
opened 04:24PM - 23 Dec 22 UTC
type:feature-request
storage:onedrive
Original issue from the old app: https://github.com/cryptomator/cryptomator-ios/… issues/139
## Status Quo
OneDrive (personal account): You can access shared folders. If you're unable to access a shared folder that was shared with you (i.e., you are not the owner), you have to [add the shared folder to your OneDrive](https://support.microsoft.com/en-us/office/add-and-sync-shared-folders-to-onedrive-for-home-8a63cd47-1526-4cd8-bd09-ee3f9bfc1504#bkmk_add).
OneDrive for Business (work/school account): You can only access shared folders that you own. Even if you [add a shortcut to "My Files"](https://support.microsoft.com/en-us/office/add-shortcuts-to-shared-folders-in-onedrive-for-work-or-school-d66b1347-99b7-4470-9360-ffc048d35a33), you cannot access the shared folder.
## Technical Details
To make this point clear: Shortcuts are not part of the [directory listing](https://learn.microsoft.com/en-us/graph/api/driveitem-list-children?view=graph-rest-1.0&tabs=http). It seems that there is no way to implement this feature transparently. So there is no way to "merge" shared files with your own files. That's actually what the shortcuts are for (in my opinion) but they're missing.
There is an API to list all shared items (not being the owner) via [`GET /me/drive/sharedWithMe`](https://learn.microsoft.com/en-us/graph/api/drive-sharedwithme?view=graph-rest-1.0&tabs=http). With these identifiers, you can access the shared folders.
## Proposed Solution
Since personal accounts are not affected by this issue, the `driveType` should be retrieved and persisted after a successful authentication. You can get it via [`GET /me/drive`](https://learn.microsoft.com/en-us/graph/api/drive-get?view=graph-rest-1.0&tabs=http).
When adding a vault in OneDrive: If the `driveType` is `business` (and maybe `documentLibrary`?!), we need to present a choice between the user's own files and shared items. An optimization could be to detect if there are any shared items at all so that the choice can be skipped. In case of shared items, we need a new screen that lists all available shared folders (shared files don't make any sense here). If one of the folder is selected, the "new" root identifier is the one from the selection (incl. drive identifier).
Caveat: If we set the selected folder as root, there will be the problem that the root folder doesn't have a name (classic example if the vault is the root folder itself). When implementing this feature, we should experiment with setting the parent reference as root but still showing the shared folder directly.
